Preferred Name and Keywords Stay After Purging Patron

[John Amundson]

Evergreen 3.2.1

When choosing the option to "Completely Purge Account", any preferred names or name keywords attached to the patron continue to exist in the database.

Is there any reason to not anonymize these like the rest of the fields on the account when it is purged?

I've attached a screenshot of the deleted record pulled up in the web client, (via database ID). Notice the purged status of the account and the how the preferred names and keywords persist.

[Jason Stephenson (jstephenson)]

I have pushed a branch that fixes this for master/3.3: user/dyrcona/lp1802166-purge-preferred-names in the working repository.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1802166-purge-preferred-names

I had made a branch for 3.2, but realized that backporting this fix is dangerous because there are other changes to the actor.usr_delete function between rel_3_2 and master. If the rel_3_2 function and the master function have the same upgrade number, then someone could update their 3.2 installation and miss getting the new features of actor.usr_delete when upgrading to 3.3 or beyond later.

Because of this, I have set the 3.2 target for this bug to Won't Fix. If someone thinks we should fix this in 3.2, I can push the branch, but whoever merges this into master and rel_3_2 will need to know to use different upgrade numbers for each branch. (I think I've seen this done in one or two cases prior to this.)

[Jason Stephenson (jstephenson)]

I added another commit to set name_keywords to NULL, so you want the top two commits on the branch.

[Galen Charlton (gmc)]

As a (small) privacy issue, I do think it needs to be fixed in 3.2.x as well. I've added the target and will take responsibility for the backports.

[Jason Stephenson (jstephenson)]

I already made a 3.2 backport branch that we're using at CW MARS in production, so I've gone ahead and pushed it: user/dyrcona/lp1802166-purge-preferred-names_rel_3_2

We may want to use different upgrade numbers for 3.2 versus master and 3.3. I applied the database change without altering db upgrade log locally.

[Rogan Hamby (rogan-hamby)]

Works as advertised, signoff for keywords and names pushed to user/rogan/lp1802166_purge_preferred_names_and_keywords_signoff

[Galen Charlton (gmc)]

Pushed all the way to rel_3_4. I added a follow-up to the release notes to mention a way of clearing the preferred name and name keyword fields from already-purged records:

UPDATE actor.usr
SET pref_prefix = NULL,
    pref_first_given_name = NULL,
    pref_second_given_name = NULL,
    pref_family_name = NULL,
    pref_suffix = NULL,
    name_keywords = NULL
WHERE usrname ~ ('^' || id || '-PURGED')
AND NOT active
AND deleted
AND (
    pref_prefix IS NOT NULL OR
    pref_first_given_name IS NOT NULL OR
    pref_second_given_name IS NOT NULL OR
    pref_family_name IS NOT NULL OR
    pref_suffix IS NOT NULL OR
    name_keywords IS NOT NULL
);

Thanks, Jason and Rogan!