SRU/Z39.50 results can include non-OPAC-visible holdings

Bug #1794884 reported by Jeff Davis
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.1
Fix Released
Medium
Unassigned
3.2
Fix Released
Medium
Unassigned
3.3
Fix Released
Medium
Unassigned

Bug Description

EG 3.1

When you do a SRU or Z39.50 search, non-OPAC-visible holdings will appear in the 852 field if the record also has holdings in scope that are OPAC-visible.

To test:

1. Create a bib record.
2. Add an item to the record at BR1. Mark it as not OPAC-visible.
3. Do a CONS-level SRU search for the record, including holdings. The record is not included in results because there are no OPAC-visible holdings.
4. Add a second item to the same record, this time at BR3. Mark this one as OPAC-visible.
5. Repeat the CONS-level SRU search, including holdings. The record appears in search results, but holdings information in 852 includes *all* copies, including non-OPAC-visible copies.

Ideally, the record would appear in search results, but holdings information in 852 would include only OPAC-visible copies.

This is actually a regression. The same issue was previously reported in bug 1025379 and fixed circa EG 2.3; I believe it was reintroduced by the fix for bug 1609556 (oops!).

tags: added: sru supercat z3950
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1609556-sru-z3950-opac-visible-copies has a fix that only includes OPAC-visible holdings in SRU/Z39.50 holdings output.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.2.2
Changed in evergreen:
milestone: 3.2.2 → 3.2.3
Changed in evergreen:
milestone: 3.2.3 → 3.2.4
milestone: 3.2.4 → 3.3-beta1
Dan Wells (dbw2)
Changed in evergreen:
importance: Undecided → Medium
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Kyle Huckins (khuckins)
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Revision history for this message
Kyle Huckins (khuckins) wrote :

I have tested this code and consent to signing off on it with my name, Kyle Huckins, and my email address, <email address hidden>.

Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
tags: added: signedoff
Changed in evergreen:
milestone: 3.3.3 → 3.3.4
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4-beta2
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed all the way to rel_3_1. Thanks, Jeff and Kyle!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.