ACQ: Within Selection List, "Save Items to Selection List" moves, not copies, lineitem(s) to another selection list

Bug #1418694 reported by Mary Jinglewski
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.1
Won't Fix
Undecided
Unassigned
3.2
Won't Fix
Undecided
Unassigned
3.3
Won't Fix
Undecided
Unassigned
3.4
Fix Released
Undecided
Unassigned

Bug Description

Evergreen 2.6+
Evergreen 2.7+

Action should be relabeled to reflect actual action as coded and/or additional coding should be implemented for "Move Items to Selection List" or "Copy Items to Selection List."

When within Selection List screen, "Save Items to Selection List" action moves lineitem(s) to another selector list rather than copying lineitem(s).

Within End User interface :
Acquisitions > My Selection Lists > Select individual Selection List through hyperlinked Selection List Name

"Save Items to Selection List" action located in Actions drop-down window where --Actions-- and --PO-- actions are located, not the in-row individual Line Item actions.

Breadcrumbs within code:
Within Open-ILS/src/templates/acq/common/li_table.tt2
 "Save Items to Selection List" is referenced in <option mask='pl|gs|vp|fs' value='save_picklist'>[% l('Save Items To Selection List') %]</option>
Additional searching shows that 'save_picklist' is also located in Open-ILS/web/js/ui/default/acq/common/li_table.js

Erica Rohlfs (erohlfs)
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
assignee: nobody → Tiffany Little (tslittle)
Revision history for this message
Tiffany Little (tslittle) wrote :

Branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=f2583d437b102083a4b6ef646ce9e34f5b7e24a4

This changes the wording from 'Save Items to Selection List' to 'Move Items to Selection List'.

Changed in evergreen:
assignee: Tiffany Little (tslittle) → nobody
tags: added: pullrequest
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Changed in evergreen:
milestone: 3.3.3 → 3.3.4
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Changed in evergreen:
milestone: 3.4.4 → 3.5.1
Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Revision history for this message
Mary Llewellyn (mllewell) wrote :

The Actions menu entry within the selection list now says Move Items to Selection List, and the items are transferred to the designated list and removed from the original list.

I have tested this code and consent to signing off on it with my name, Mary Llewellyn and my email address, <email address hidden>.

Changed in evergreen:
assignee: nobody → Mary Llewellyn (mllewell)
tags: added: signedoff
Changed in evergreen:
assignee: Mary Llewellyn (mllewell) → nobody
Revision history for this message
Jason Boyer (jboyer) wrote :

Pushed to rel_3_4, rel_3_5, and master; thanks Tiffany and Mary!

Changed in evergreen:
assignee: nobody → Jason Boyer (jboyer)
Jason Boyer (jboyer)
Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Jason Boyer (jboyer) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.