Accessibility issues with the Register Workstation button

[Jane Sandberg]

The "Register" button on the Angular Workstation administration screen has two accessibility problems: one in light mode and one in dark mode.

In light mode, there is very little contrast between the text and button background when the button is focused. In dark mode, the contrast is fine, but there is no focus indicator when the button is focused. I think the button is fine when not focused. The AngularJS workstation administration screen is fine, it's just the Angular one that has problems.

This is on today's main branch. I saw this in Firefox, haven't checked other browsers yet.

Steps to recreate:

1. Go to /eg2/en-US/staff/admin/workstation/workstations/manage
2. Switch to Light Mode if you aren't already using it
3. Type a Workstation Name.
4. Press the Tab key
5. Note that the Register button is almost unreadable: white text on very light grey background.
6. Switch to Dark Mode.
7. Tab back to the Register button.
8. Note that it is readable, but there is no particular indication that the Register button has focus (if you are watching *very* closely, you can notice a very subtle change in text color, but it is quite easy to miss).

[Stephanie Leary (stephanieleary)]

We had placed the logic to set the color mode *after* the user login, for some reason. This was causing several issues.

Here's a branch that fixes the contrast issues with the button as well as the background of the password visibility toggle:
user/sleary/LP2089597-login-form-contrast-issues

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP2089597-login-form-contrast-issues

This may fix other issues with the color modes.

[Terran McCanna (tmccanna)]

Getting a merge conflict in /app/staff/nav.component.ts against 3.15 beta

[Stephanie Leary (stephanieleary)]

Updated!

[Llewellyn Marshall (lbmarshallv)]

I'm looking at this patch on Blake's test server and my own and I'm still seeing the white text on the "register" button at /eg2/en-US/staff/admin/workstation/workstations/manage

[Terran McCanna (tmccanna)]

Seeing the same behavior as Llewellyn. Adding needswork tag.

[Stephanie Leary (stephanieleary)]

Thanks for testing! I found the issue with the hover/focus color and pushed a follow-up commit.

[Blake GH (bmagic)]

Merge conflict on main today. I think I resolved it for bugsquashing week but there was something strange with git's reconciliation in Open-ILS/src/templates/staff/css/styles-colors.css.tt2

[Susan Morrison (smorrison425)]

Confirmed in light and dark modes that the Register button focus is now consistent with the other buttons on this page. There is no change in the text color, and it's visibly outlined when tabbed to.

I have tested this code and consent to signing off on it with my name, Susan Morrison,
and my email address, <email address hidden>.

[Jane Sandberg (sandbergja)]

Thanks, Stephanie, Susan, and all others who have worked with this bug. I squashed the two commits together, and pushed to rel_3_14 and above.