Bootstrap OPAC: "Delete Selected" Button in the circulation history have not been marked for translation

Bug #2076420 reported by Eva Cerninakova
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Undecided
Unassigned
3.12
Fix Committed
Undecided
Unassigned
3.13
Fix Committed
Undecided
Unassigned

Bug Description

Bootstrap OPAC: "Delete Selected" Button in the circulation history have not been marked for translation.

The problem is with the template Open-ILS/src/templates-bootstrap/opac/myopac/circ_history.tt2:36

The correct code should be:

<i class="fas fa-trash-alt" aria-hidden="true"></i> [% l('Delete Selected') %]</button>

Revision history for this message
Stephanie Leary (stephanieleary) wrote :
tags: added: pullrequest
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Linda Jansova (skolkova-s) wrote :

Using Blake's bugsquash server (https://bugsquash.mobiusconsortium.org/eg/opac/myopac/circ_history; now it can be accessed via the admin's account which has circulation history enabled and one item has been checked out and then checked in) I can confirm that Stephanie's patch makes the string availalable for translation and the translation appear in the interface.

tags: added: signedoff
Revision history for this message
Linda Jansova (skolkova-s) wrote :

I have tested this code and consent to signing off on it with my name, Linda Jansova, and my email address, <email address hidden>.

Changed in evergreen:
milestone: none → 3.14-beta
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
status: Confirmed → Fix Committed
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks Linda and Stephanie!

Fix merged to main, rel_3_13, and rel_3_12.

Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.