Search suggestions for long searches can take too long to calculate

Bug #2059974 reported by Mike Rylander
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.11
Fix Released
High
Unassigned
3.12
Fix Released
High
Unassigned

Bug Description

Evergreen version: 3.11+

The suggestion efficacy testing done for "did you mean" suggestions requested against long user searches can take a very long time. It's also probably not useful to the user to look for many spelling-corrected suggestions on 20 word searches.

The next planned enhancement to the Did You Mean functionality will focus partly on making suggestion calculation smarter internally rather than effectively generating suggestions for each word separately and then testing and combining them all at the end. But, as an intermediate stop-gap, we can limit size of the user searches for which we will offer suggestions.

Branch forthcoming...

Revision history for this message
Mike Rylander (mrylander) wrote :

Here's a branch that adds a Global Flag to control the search length cap for spelling-based suggestions:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-2059974-restrict-dym-search-length

tags: added: pullrequest search
Changed in evergreen:
assignee: Mike Rylander (mrylander) → nobody
no longer affects: evergreen/3.10
Andrea Neiman (aneiman)
Changed in evergreen:
status: In Progress → Confirmed
Changed in evergreen:
milestone: 3.13-beta → 3.13-rc
Revision history for this message
Elizabeth Davis (elidavis) wrote :

I have tested this code and consent to signing off on it with my name, elizabeth davis and my email address, <email address hidden>

Andrea Neiman (aneiman)
tags: added: signedoff
Revision history for this message
Blake GH (bmagic) wrote :

Thanks everyone! I confirmed that the DB script runs on a new install as well as an upgrade. I also confirmed that with the patch, the sym spell doesn't get invoked when there are more than 3 words in the search string.

I've pushed to 3.11, 3.12, 3.13 and main

Changed in evergreen:
status: Confirmed → Fix Committed
Andrea Neiman (aneiman)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.