Angular Daily Cash Report missing print capability

Bug #2003090 reported by Terran McCanna
34
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Undecided
Unassigned
3.11
Fix Committed
Undecided
Unassigned
3.12
Fix Committed
Undecided
Unassigned

Bug Description

EG 3.10 Angularized Daily Cash Report

It is no longer possible to use the browser's print function to print the Daily Cash Report (it gives a blank scren).

Print Full Grid does work to print the grid portion, but it leaves off the summary portion at the top of the page.

tags: added: printing
Revision history for this message
Terran McCanna (tmccanna) wrote :

Additional information - the libraries inform me that their auditors need to have the dates on the print out. There isn't a date column, so printing full grid / downloading CSV doesn't include the dates (and of course, doesn't include the summary info on top).

summary: - Angular Daily Cash Report missing print option
+ Angular Daily Cash Report missing print capability
tags: added: regression
Revision history for this message
Terran McCanna (tmccanna) wrote :

And more info - each row is a summary, so a date column wouldn't work anyway. It looks like it will need a print template developed to make this work.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Terran, until we can fix printing in a more general way, could the folks who need to print the cash report toggle a user stylesheet? This would be a quick and dirty way to let the print the screen they need:

@media print {
 body {
  display: block !important;
 }
}

But you wouldn't want to leave that on all the time; it would hijack the more specialized printing features, like receipts.

Revision history for this message
Dan Briem (dbriem) wrote :
tags: added: pullrequest
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks so much, Dan! I've tested this and it works great and we're putting it on our production server.

However, I'm holding off on signing off because I wonder if it would be better for the Evergreen product if this used a Print Template instead of having the print layout controlled by the Angular code. Adding needsdiscussion tag for more input.

tags: added: needsdiscussion
Revision history for this message
Galen Charlton (gmc) wrote :

I agree that using the print templates would be a good idea rather than hard-coding the template.

Revision history for this message
Terran McCanna (tmccanna) wrote :

See larger discussion about printing Angular pages: https://bugs.launchpad.net/evergreen/+bug/1949999

Dan Briem (dbriem)
tags: removed: pullrequest
Dawn Dale (ddale)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

Confirmed printing via the browser still give a blank screen in 3.11

Revision history for this message
Ruth Frasur Davis (redavis) wrote :

Confirming that this a major issue for some our libraries.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Jennifer & Ruth - Dan's branch in comment 4 is a viable workaround until further development is done.

Revision history for this message
Michele Morgan (mmorgan) wrote :

I've taken the liberty of rebasing Dan's patch, branch is here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp2003090_rebase

user/mmorgan/lp2003090_rebase

Also noting that we have been using this workaround in production for some time.

Revision history for this message
Terran McCanna (tmccanna) wrote :

We've also been using Dan's workaround in production for over a year. Are there any objects to committing this to main until there is a viable replacement for the functionality?

Revision history for this message
Michele Morgan (mmorgan) wrote :

No objection from me to committing this until there is a viable replacement! I've re-added the pullrequest tag.

tags: added: pullrequest
removed: needsdiscussion
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Merged as far back as rel_3_11

tags: added: signedoff
Changed in evergreen:
milestone: none → 3.13.1
status: Confirmed → Fix Committed
assignee: Terran McCanna (tmccanna) → nobody
Changed in evergreen:
milestone: 3.13.1 → 3.13.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.