Angular staff client navbar is not responsive
Bug #1945498 reported by
Galen Charlton
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
3.12 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
The Angular staff client's navbar is not responsive. For example, particularly on phones, it
- its height expands, covering parts of the interface
- Unlike the AngularJS version, it doesn't shrink down to a bar with a hamburger menu; instead, it displays full width, and consequently gets cut off. The latter can be an issue with tablet display
It should be adjusted so be fully responsive, similar to the examples at https:/
I've attached a screenshot of the problem. While there may or may not be little call to use the Angular staff client on phones, there certainly is for tablets.
Evergreen 3.6+
tags: | added: accessibility angular |
tags: | added: usability |
Changed in evergreen: | |
status: | New → Confirmed |
tags: | added: needswork |
Changed in evergreen: | |
assignee: | nobody → Galen Charlton (gmc) |
tags: | removed: signedoff |
Changed in evergreen: | |
assignee: | nobody → Terran McCanna (tmccanna) |
tags: | added: signedoff |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Here's a branch that makes the nav menu responsive: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ sleary/ LP1945498- responsive- navbar
The keyboard events are verbose, but the ng-bootstrap Collapse functionality (https:/ /ng-bootstrap. github. io/#/components /collapse/ examples#navbar) was written as a simple click handler, which doesn't support keyboard users, so here we are. If nothing else, this demonstrates why I've spent so much time converting links to buttons elsewhere in the interface.