Permission issue in Receive Shipment feature

[Llewellyn Marshall]

Evergreen 3.11.1

Staff have been unable to use the Receive Shipment feature in the Acquisitions module. When they attempt to scan a barcode pulled from the DESADV EDI message, they get this error: “No container found with barcode…” However, our global admin account was able to successfully receive a shipment. From that, we deduced that it was most likely a permission issue.

We looked into the FM_IDL and found that there are MANAGE_SHIPMENT_NOTIFICATION and VIEW_SHIPMENT_NOTIFICATION permissions required for retrieving and editing shipment notifications, however, these permissions were missing from the SQL upgrade scripts and 950 data seed files. The feature worked once the permissions were added and mapped to our staff permission groups.

I'm going to create a patch to add these permissions.

[Llewellyn Marshall (lbmarshallv)]

My patch:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/lew/lp2055089-missing-notification-permissions

[Galen Charlton (gmc)]

Took a quick look - in the change to 950.data.seed-values.sql, the ID that's the first parameter of oils_i18n_gettext() does not match the ID assigned for the permission as a whole.

For the upgrade script, I suggest adding a "WHERE NOT EXISTS (SELECT 1 FROM permission.perm_list WHERE code = 'XXX')" clause to each insert statement similar to what's going on in 1401.data.lp2051140_missing_bucket_perms.sql. That way, the update will not error out for anybody who may have manually added the missing permissions.

[Terran McCanna (tmccanna)]

Thanks, Llewellyn!

Tested by the New Developers Working Group. Sign off branch is at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=25e5aa7d109b6828612d5321fdb3a672fe2bfa5c

[Galen Charlton (gmc)]

Pushed down to rel_3_11. Thanks, Llewellyn, Terran, Steven, and Michele!