Selfcheck: Cover art for holds without ISBNs isn't shown

[Josh Stompro]

EG 3.11 and earlier.

There is a bit of weird logic that is probably left over from when added content could only lookup based on ISBN that skips cover art for holds that don't have an ISBN.

In Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js on line 841
    if(data.mvr.isbn()) {
        this.byName(row, 'jacket').setAttribute('src', '/opac/extras/ac/jacket/small/r/' + data.mvr.doc_id());
    }

I just noticed that my hold for a hotspot wasn't showing cover art today, which we have stored locally on the server.

The checkout interface and items out interface just check for a bib id before adding the cover art.

    if(record.doc_id()) {
        this.byName(row, 'jacket').setAttribute('src', '/opac/extras/ac/jacket/small/r/' + record.doc_id());
    }

I think just getting rid of the isbn check will fix this.

[Garry Collum (gcollum)]

I thought I would test Josh's theory and it worked. He should get credit for https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=9711dcf08fcd504ced7cd743c0f4f71a40f7d00b

[Galen Charlton (gmc)]

Tested and signed off: working/user/gmcharlt/lp2037564_signoff

[Galen Charlton (gmc)]

The patch is straightforward and it's been long enough, so I've merged it down to rel_3_11. Thanks, Josh and Garry!