Web Staff Client - Accessibility and the Item Edits Page

[Mike Risher]

The page that lets you edit items and edit item templates needs to have labels added so that they're easier to use with screen readers. Check all the various input fields on these forms.

[Mike Risher (mrisher)]

I pushed a branch with these changes:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1887869-item-edits-accessibility

Please note that a few of the changes rely on edits to shared directives. These edits are already done and can be found on bug 1887866.

[Terran McCanna (tmccanna)]

Mike, I got a merge conflict when I tried to cherry-pick this to current master. Any chance you could rebase?

[Mike Risher (mrisher)]

Terran, here's a branch that's been cherry picked from the current master

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1887869-item-edits-accessibility-cp

[Mike Risher (mrisher)]

Testing instructions:

1. You'll need a screen reader for testing. JAWS and NVDA are popular options. Instructions here: https://developer.paciellogroup.com/blog/2015/01/basic-screen-reader-commands-for-accessibility-testing/

If installing a screen reader isn't practical, Firefox can be used to test accessibility also. https://developer.mozilla.org/en-US/docs/Tools/Accessibility_inspector

2. Load changes to both the shared directives (bug #1887866) and these changes to the item edit pages (branch is in comment #3 above)

3. Test to see if the issues in the bug description have been addressed

[Terran McCanna (tmccanna)]

I loaded this in conjunction with the patch for lp1887866 for testing and went through the fields with the Firefox accessibility inspector and all the label names came through correctly. Thanks! My signoff is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1887869-item-edits-accessibility-cp-signoff

[Galen Charlton (gmc)]

Will commit when the merge window reopens after the May releases.

[Stephanie Leary (stephanieleary)]

Looking more closely, the ARIA labeling strategy needed significant revision. I have a WIP branch at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=b96e0d127919a673829d11ae990177c7a510bd80 but this needs additional review and testing.

[Terran McCanna (tmccanna)]

Note: Top 3 commits at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1887869-item-edits-accessibility

[Ruth Frasur Davis (redavis)]

Using Axe DevTools, I scanned the entirety of the Holdings Editor with both the Unified Holdings and Item Attributes Display selected and deselect. With the Unified Holdings and item Attributes Display selected, seven (7) "form elements must have labels" issues were highlighted. 6 of the 7 were related to the Holdings Editor (only one field has a label). The 7th issue was for the "Templates" field that appears in the Items Attributes Display when the unified setting is deselected.

https://axe.deque.com/issues/8246ed53-fbfe-4198-9d6c-cea584c9e07b

[Terran McCanna (tmccanna)]

Removing milestone for 3.12 as this needs more work.