autogen.sh should accept a parameter pointing to opensrf_core.xml

[Jason Boyer]

Most OpenSRF / Evergreen commands accept a parameter pointing to opensrf_core.xml in case you change the name or move it to another location, but autogen.sh does not. Since you need autogen to work to have a fully functioning OPAC, that needs to change.

[Jason Boyer (jboyer)]

Like so: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp2003707_core_autogen / working/user/jboyer/lp2003707_core_autogen

[Jason Boyer (jboyer)]

Note, I'm targeting this at point releases because I consider it a bug that it's never been done before, but if others feel strongly about it then it can just go to 3.11.

[Josh Stompro (u-launchpad-stompro-org)]

Hello, I just tested this out and it seems to work well.

I ran it like the old version of the script and the output matched. I moved my opensrf_core.xml and ran it with the path to the file and everything worked like it should.

Signoff branch at: user/stompro/lp2003707_core_autogen-signoff

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp2003707_core_autogen-signoff

I did notice that build/tools/update.sh includes a line that seems like it is trying to call autogen.sh with a specific opensrf_core.xml file, but it probably wasn't working as intended. I'm not sure if it matters or not.

cd $INSTALL/bin; ./autogen.sh ../conf/opensrf_core.xml;

Josh

[Galen Charlton (gmc)]

I dug a bit into the history and found a couple things:

- build/tools/update.sh is no longer a factor; it's a helper script to assist with upgrades on a developer installation of Evergreen, but it hasn't been touched in years. We should probably remove it.
- However, time was that autogen.sh did have a parameter for specifying the location of opensrf_core.xml. However, that was dropped in 2011 on the basis that OpenILS/Utils/Cronscript.pm gets updated during installation with the path to opensrf_core.xml.

However, it is no longer a safe assumption that Cronscript.pm always points to the proper location of opensrf_core.xml; Equinox at least runs multi-tenant Evergreen setups that operate with a shared PERL5LIB but separate opensrf_core.xml configs.

This does suggest a cautionary note during upgrade: if you're running with opensrf_core.xml located anywhere other than /openils/conf in a single-tenant manner, make sure that SYSCONFDIR as set in autogen.sh matches what's set in the installed Cronscript.pm.

[Galen Charlton (gmc)]

Pushed all the way down to rel_3_8. Thanks, Jason and Josh!