Web client- no popup warning for invalid barcode

[Janet Schrader]

In the xul client if you check the box for "Use checkdigit" and enter an invalid barcode there is a popup you have to close before you can continue. You could still save the item if you were entering barcodes that started with a letter or were dummy barcodes. This is missing in the web client. There the only warning for an invalid barcode is a red outline around the barcode box. ​It seems too easy for busy staff to miss this outline. Is it possible to get something more obvious? If the call number or barcode is missing, a warning message appears in small red print under the boxes, which is at least a bit more conspicuous. If no popup, I'd like to see something similar for an invalid barcode. It would also be nice to have the Save & Exit button turn very red so staff will notice it when they go to save and hopefully look to correct the problem before they click on it.

Release 3.0.13 and 3.2.8. Chrome browser

[Jennifer Pringle (jpringle-u)]

This continues to be an issue in 3.7.

The red outline is so thin and faint in 3.7 that I didn't even notice it until after finding this bug.

[Janet Schrader (jschrader)]

This is also true in 3.5 and please note: the red outline is only there as long as the cursor is in the box; once you move on to another field the faint red outline goes away.

[Mary Llewellyn (mllewell)]

I'm testing 3.8 and Use Checkdigit doesn't seem to be working at all. I've been able to add items with deliberately incorrect barcodes.

[Elaine Hardy (ehardy)]

I can confirm that it isn't functioning in 3.8

[Jennifer Pringle (jpringle-u)]

I can confirm that Use Checkdigit does nothing in 3.9 in the new holdings editor.

[Jessica Woolford (jwoolford)]

Here's a branch that adds a check for an invalid barcode if "Use Checkdigit" is checked, and will show a message and prevent saving if the check fails, similar to the way the check for a duplicate barcode functions. The code for the barcode validity check is borrowed from the Angular patron interfaces.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jwoolford/lp1814966-warning-for-invalid-barcode

A note for committers: There are now two commits on this branch that will need to be squashed. If this fix is implemented along with the fix for 1998494, they will conflict, so probably easiest to apply the minor fix from that bug/branch here before merging if both are accepted.

[Elaine Hardy (ehardy)]

I tested this and once you navigate from the barcode input, the barcode and well turns red and the message invalid barcode appears in red below it. The save buttons are not active.

 I have tested this code and consent to signing off on it with my name, Elaine Hardy and my email address, <email address hidden>.

[Michele Morgan (mmorgan)]

When the Use checkdigit box is checked, this patch does work to alert the user that they have entered an invalid barcode.

However, the user has no way to dismiss the warning and proceed to save the item with the invalid barcode. In previous versions of Evergreen, entering an invalid barcode prompted a warning only, it was still possible to proceed and save the item.

Unchecking the checkbox did not allow saving without reloading the page reentering the data.

I'm not sure we can assume a user would never want to save an item with an invalid barcode.

[Elaine Hardy (ehardy)]

My assumption is that you would not check the box if your barcodes were "invalid" even if you have a mix of valid and invalid ones since the original purpose of the checkbox was to prevent scanning errors. Which were common with the scanners we had at the time.

FYI: I did not have to reload the page after unchecking the box. I was able to reenter the barcode and save.

[Michele Morgan (mmorgan)]

I tested this again during Feedback Fest and consulted with colleagues on this. The workflow required when "Use Checkdigit" is enabled, but the staff user intentionally needs to save a nonstandard barcode is problematic. The steps required were:

Uncheck the "Use Checkdigit" box, reload the page and reenter the item data, save the item, re-check the "Use Checkdigit" box.

OR

Uncheck the "Use Checkdigit" box, change the barcode field to something different, click outside the barcode entry box, then reenter the desired nonstandard barcode, save the item, re-check the "Use Checkdigit" box.

It would make for a more manageable workflow if there were a popup to allow the user to override the barcode check.

[Bill Erickson (berick)]

Removing signedoff tag pending resolution/consensus on the last few comments.