SRU incorrect nesting of site param

[Jeff Davis]

When you do an SRU search at a specific org unit, a "site" parameter is appended to your search terms in a way that can mess up your query.

Suppose you submit this search to /opac/extras/sru/SYS1/holdings:

eg.keyword = 9780387095141 or eg.keyword = 0387095144

Evergreen extracts the SYS1 shortname from the endpoint URL and simply appends it to your query:

SRU search string [eg.keyword = 9780387095141 or eg.keyword = 0387095144] converted to [eg.keyword:9780387095141 || eg.keyword:0387095144 site:SYS1]

There's an order-of-operations problem here. We intended this:

( eg.keyword:9780387095141 || eg.keyword:0387095144 ) site:SYS1

But we effectively got this instead:

eg.keyword:9780387095141 || ( eg.keyword:0387095144 site:SYS1 )

The easiest solution is to wrap our entire query in parentheses before appending the site param. I'll share a branch for this momentarily.

[Jeff Davis (jdavis-sitka)]

Note that Boolean searches of site-scoped Z39.50 endpoints will be affected by this bug, since Z39.50 uses SRU.

****

Working branch user/jeffdavis/lp1833300-sru-site-param-nesting has the aforementioned fix.

To test:

1. Submit an SRU search to /opac/extras/sru/SYS1/holdings?version=1.1&operation=searchRetrieve&query=(eg.keyword%20=%209780387095141%20or%20eg.keyword%20=%200387095144)&maximumRecords=0

2. Logs should show the search with the incorrectly nested site param:
SRU search string [(eg.keyword = 9780387095141 or eg.keyword = 0387095144)] converted to [eg.keyword:9780387095141 || eg.keyword:0387095144 site:SYS1]

3. Apply the patch and restart Evergreen.

4. Redo the search from step 1.

5. Logs should show that the site param is now correctly nested:
SRU search string [eg.keyword = 9780387095141 or eg.keyword = 0387095144] converted to [(eg.keyword:9780387095141 || eg.keyword:0387095144) site:SYS1]

[Mike Risher (mrisher)]

I ran through the testing steps and can confirm that parentheses group the search parameters in the way described. I consent to signing off on it with my name, Mike Risher and my email address, <email address hidden>

[Galen Charlton (gmc)]

Pushed all the way to rel_3_4. Thanks, Jeff and Mike!