Adjust to Zero does not set item status to Lost and Paid

Bug #1830089 reported by tji@sitka.bclibraries.ca on 2019-05-22
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.1
Undecided
Unassigned
3.2
Undecided
Unassigned
3.3
Undecided
Unassigned

Bug Description

EG 3.1.7

With the library setting To Use Lost and Paid copy status set to True, we see the following behaviour:

For a bill amount of 14.82, apply cash payment of 14.80, then use Adjust to Zero to settle the leftover 2 cents. The item status remains Lost.

For a bill amount of 16.00, apply cash payment of 16.00. The item status is set to Lost and Paid.

tags: added: billing
tji@sitka.bclibraries.ca (tji) wrote :

Voiding lost (full or partial) bills does not change the item status to Lost and Paid, either.

For a lost bill with two billings: replacement charge and processing fee. Make payment on the replacement cost, go to Full Details to void the processing fee. The bill is resolved, but the item status remains Lost.

Jeff Davis (jdavis-sitka) wrote :

I've opened bug 1832410 for the issue with voiding bills, which is a related but separate bug.

Working branch user/jeffdavis/lp1830089-lost-and-paid-on-adjust-to-zero has a fix for adjust-to-zero:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1830089-lost-and-paid-on-adjust-to-zero

The fix refactors some code so that regular payments and adjust-to-zero use the same subroutine to close the transaction and adjust item status. It's slightly inelegant because they handle errors differently: make_payments wants a text string that it can pass to an error-handling function, while adjust_bills_to_zero_manual expects an event. But it works.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.4-beta1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers