Include Call Number Suffix when sorting copies in the public catalog

Bug #1795469 reported by Jane Sandberg
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.1
Won't Fix
Undecided
Unassigned
3.2
Won't Fix
Undecided
Unassigned
3.3
Won't Fix
Undecided
Unassigned
3.4
Fix Released
Medium
Unassigned

Bug Description

Currently, the copies displayed in the public catalog view are sorted by the following fields:
* Org unit name
* Call number sortkey
* Part sortkey
* Copy number
* Copy barcode

This leaves out call number suffixes. We use call number suffixes for volume numbers (e.g. V.1, V.2), so it seems very natural to include those in the sort as well, maybe between call number sortkey and part sortkey.

This commit seems like a very good model for accomplishing this: https://github.com/evergreen-library-system/Evergreen/commit/ef697352585e0f7fff258e4fbec1dec03cf839ce

Revision history for this message
Jane Sandberg (sandbergja) wrote :

I just created a branch for this called user/sandbergja/lp1795469_add_cn_suffix_to_opac_holdings_order

Here is a link: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1795469_add_cn_suffix_to_opac_holdings_order

And here are the testing notes from the commit message:

To test:
1) Create a bunch of Call Number suffixes in Administration -> Server Administration -> Call Number Suffixes.
2) Go to a bib record, and add a bunch of holdings, all with the same call number label, owning/circ libraries, item numbers, and parts (if using parts) but with different barcodes and CN suffixes.
3) Look at the OPAC view of these holdings. Note that they are in order by barcode, without any consideration for the CN suffix.
4) Apply this commit.
5) Look at the OPAC view again. Note that they are now sorted by CN suffix, and then by barcode.

tags: added: pullrequest
Changed in evergreen:
status: New → Confirmed
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

This worked for me, remember to restart apache when testing to apply the change on a running system, took me a few minutes to remember that.

Signoff working branch at: user/stompro/lp1795469_add_cn_suffix_to_opac_holdings_order_signoff

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1795469_add_cn_suffix_to_opac_holdings_order_signoff

Josh

tags: added: signedoff
Changed in evergreen:
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.3.1
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Changed in evergreen:
milestone: 3.3.3 → 3.3.4
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Changed in evergreen:
importance: Undecided → Medium
milestone: 3.4.4 → 3.3.8
milestone: 3.3.8 → 3.5.1
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_5, and rel_3_4. Thanks, Jane and Josh!

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.