Record bucket egGrid should disable the "Merge Records" action unless two or more records are selected

Bug #1760599 reported by Jane Sandberg
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.1
Fix Released
Low
Unassigned
3.2
Fix Released
Low
Unassigned

Bug Description

On current master and 3.1.0. Merging 1 record doesn't really make sense, and the Merge Records modal enforces this. However, it would be better to not even allow the option of opening the modal until the user has selected two or more items from the record bucket grid.

Steps to re-create:
1) In Web client, go to Cataloging > Record buckets.
2) Open or create a bucket with one or more records in it.
3) Select one record from your bucket. Right-click on your record or click on the Actions drop-down.
4) "Merge Selected Records" is enabled. Expected behavior is that it be disabled.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

I created a branch to fix this, called user/sandbergja/lp1760599_disable_merge_records_unless_multiple_records_selected

Here's a link: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1760599_disable_merge_records_unless_multiple_records_selected

Here are testing instructions from the commit message:

1) Create a bucket.
2) Select one record from your bucket. Right-click on your record or click on the Actions drop-down.
3) Note that "Merge Selected Records" is clickable.
4) Apply this commit.
5) Repeat steps 2-3. Note that "Merge Selected Records" is no longer
clickable, unless you select two or more records.

tags: added: pullrequest
Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Works as advertised. Sign off pushed to user/rogan/lp1760599

tags: added: signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.3.1
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_3, rel_3_2, and rel_3_1. Thanks, Jane and Rogan!

Changed in evergreen:
status: New → Confirmed
assignee: nobody → Galen Charlton (gmc)
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.