Web Client: The Mark Damaged Popup has untranslateable strings

[Terran McCanna]

In 3.0.2: The "Charge Fees" and "No Charge" button strings in the "Mark Damaged" popup window are not coded as translatable strings.

[Jane Sandberg (sandbergja)]

I created a branch for this here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1742523_making_mark_damaged_strings_translatable

But I have not tested it at all, and in fact, I can't figure out how to make that particular popup appear in master. Could you remind me how to get to it?

[Jane Sandberg (sandbergja)]

Haha never mind; I didn't have the "Charge item price when marked damaged" library setting set to true. I'm adding the pull request tag so that others can help to test this.

[Jason Stephenson (jstephenson)]

Add my signoff here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1742523_making_mark_damaged_strings_translatable-signoff

I'm not sure if we're back porting translation changes, so I just signed off and pushed to working. The signoff branch is rebased on master as of about 12:45 pm EDT 2019-08-01.

[Galen Charlton (gmc)]

I believe we are backporting translation changes, so I've pushed this to master, rel_3_3, rel_3_2, and rel_3_1. Thanks, Jane and Jason!