z39.50 service sorting is incorrect

Bug #1119370 reported by Michael Peters
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

Evergreen 2.2

Z39.50 Import Service and Credentials interface appears to sort alphabetically. Recently, I noticed that is only partially true.

All capitalized service names are sorted alphabetically first, followed by lower case alphabetically.

For example:

biblios.net sorts at the very end of a list that begins with "Brodart" and ends with "Seattle". See attached screenshot for more clarification.

Changing the service name to a capital "B" in biblios.net sorts properly, but this is only a workaround.

Revision history for this message
Michael Peters (mrpeters) wrote :
tags: added: z39.50
Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
importance: Undecided → Wishlist
Galen Charlton (gmc)
tags: added: z3950
removed: z39.50
Revision history for this message
Jane Sandberg (sandbergja) wrote :

I created a branch that does this here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1119370_fix_z3950_service_sorting

My branch uses angular to sort all those services properly (not separating out the lower case ones). The Local Catalog is still listed at the very bottom, even if there are other record sources that fall later in the alphabet. I think this is fine, since the local catalog is kind of a special case anyway, but I'd be curious to hear what other folks think.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Here's a screenshot of the sorted version from my branch

tags: added: pullrequest sorting
Revision history for this message
Ben Shum (bshum) wrote :

Worked for me, fixing this for web client only. Thanks Jane! Pushed to master and backported to rel_3_1.

Changed in evergreen:
milestone: none → 3.2-beta
importance: Wishlist → Medium
status: Triaged → Fix Committed
no longer affects: evergreen/3.1
Changed in evergreen:
milestone: 3.2-beta → 3.1.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.