Webstaff: Lines added to checkout grid blank on checkout
Bug #1794176 reported by
Dan Wells
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
High
|
Unassigned | ||
3.0 |
Fix Released
|
Undecided
|
Unassigned | ||
3.1 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When performing a checkout on current webstaff master (circa 3.2-rc), the checkout rows are blank. If you switch interfaces and return, or do another checkout, the data for that row appears normally. This is likely due to additional runs of $scope.
One working fix is to simply add $scope.
Changed in evergreen: | |
milestone: | none → 3.2-rc |
importance: | Undecided → High |
summary: |
- Webstaff: Checkout grid shows blank lines on checkout + Webstaff: Lines added to checkout grid blank on checkout |
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
assignee: | nobody → Bill Erickson (berick) |
Changed in evergreen: | |
assignee: | nobody → Dan Wells (dbw2) |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix pushed:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ berick/ lp1794176- grid-tooltip- more-dynamic
Long story short, the grid tooltip logic captured cell contents into a variable so it could use the same data for both the tooltip and the cell contents, this way it would not have to generate values twice for each cell. It was essentially caching grid values inside an ng-init variable. Doh! Rolled back the optimization.
Included is a change to how the tooltips are generated for HTML-compiled cells. Instead of showing the compiled HTML it shows the text extracted from the HTML, similar with what's displayed in the CVS/Print grid. This was necessary to avoid a $digest loop. The only difference this should make in practice is it's not possible to click on links (etc) embedded in grid tooltips.