Web Client: Ability to remove more fields in Vol/Copy Editor

[Jason Stephenson]

The branch for bug 1749996 added the ability to remove the floating group option in the vol/copy editor as well as the copy template editor.

In comment #15 on bug 1759327 (https://bugs.launchpad.net/evergreen/+bug/1759327/comments/15), Janet Schrader requested that additional fields have the ability to remove options as well:

I think the ability to remove an option should also be available for "Age-based hold protection", "Loan duration", and "Fine level" too. If one of these is accidentally chosen there is no way to remove it.

I should have a branch, soon.

[Janet Schrader (jschrader)]

Jason, Duelling tagging. :) I changed the tags because "wewbstaffclient" had no hits in Launchpad. webclient had a few, but "web client" (2 words) has over 400. I also think this sounds like removing the field from being visible in the template and not removing values, entries, or menu choices from a field. I wasn't sure how to tag that.

[Janet Schrader (jschrader)]

Forgot to say I did look at our server where the branch is visible and like it. I see that all the fields I mentioned now have "<NONE>" as a choice but for Fine level and Loan duration this is not the default. Was there a reason for this? To be consistent I think the 'none' choice should display as the default.

[Jason Stephenson (jstephenson)]

There wasn't really much thought behind it. The Fine Level and Loan Duration selection lists are hard coded rather than built from the database. They already had Normal selected as the default, and I didn't think to change it. It also makes me wonder if we really need to be be able to blank those two fields.

Could they be set to empty values in XUL?

[Elaine Hardy (ehardy)]

I don't see a case where the fine level and loan duration attributes would be blank. For fine level, even if you had a no fines option, that would be one of the level options.

[Terran McCanna (tmccanna)]

Janet - about the tagging: Launchpad's basic search doesn't search the tags (I agree, that's annoying), but from the main bug screen you can see a tag list and click on that (webstaffclient has 397), or you can search tags in the advanced search.

[Mike Rylander (mrylander)]

Indeed, fine level and loan duration /cannot/ be blank. The "Normal" option is the default because it's the designed default, as the fields /must/ have a value.

[Jason Stephenson (jstephenson)]

Here's a branch that only adds a <NONE> option to age based copy protection:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1772993-blank-age-hold-protection

It's the top commit, of course.

[Elaine Hardy (ehardy)]

Tested on PINES test server Can add and remove (set to <NONE> age protection. Also tested by placing hold on copy where age protection was set and then removed. Was able to place hold on that item.

[Jeff Davis (jdavis-sitka)]

Signoff in user/jeffdavis/lp1772993-blank-age-hold-protection-signoff:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1772993-blank-age-hold-protection-signoff

[Jason Stephenson (jstephenson)]

We have been using this branch in production at CW MARS since we upgraded to 3.0.8 on May 28. I am going to push it to master, 3.1, and 3.0 since Jeff Davis has signed off.