Web Client: Print Transit List is not printing Transits

Bug #1750630 reported by Lynn Floyd
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.0
Fix Released
High
Unassigned

Bug Description

When printing the Transit List in the Web client in 3.0.3, nothing prints.

This is true even in the template.

Revision history for this message
Lynn Floyd (lfloyd) wrote :

Here is the screen shot.

Revision history for this message
Christopher Burton (cburton) wrote :

This is because {{transit.source_send_time | date:}} has a colon at the end in the template. Remove that to be {{transit.source_send_time | date}} and the template should work.

It did for me!

Revision history for this message
Christopher Burton (cburton) wrote :

or use this instead for a proper date and time

 {{transit.source_send_time | date:$root.egDateAndTimeFormat}}

Revision history for this message
Christine Burns (christine-burns) wrote :

Can confirm that updating the print template fixes this issue

Either option works

1) Remove the ":" from {{transit.source_send_time | date:}}

2) use {{transit.source_send_time | date:$root.egDateAndTimeFormat}} this looks better

Revision history for this message
Lynn Floyd (lfloyd) wrote :

Looking at the Code, it has date:$root.egDateAndTimeFormat. But I noticed that that line had double quotes instead of single quotes.

Attached is the file with a single quote for that line.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

I confirmed the issue on a 3.1.0 test server. Here's a branch that implements Lynn's fix, which worked for me:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1750630-print-transit-list

I'm not sure how to properly credit Lynn for this fix in git.

Changed in evergreen:
status: New → Confirmed
tags: added: pullrequest
Revision history for this message
Garry Collum (gcollum) wrote :
tags: added: signedoff
Revision history for this message
Jason Stephenson (jstephenson) wrote :

When you commit, you can change the author like so:

git commit --author="First Last <email address hidden>"

if you're using command line git.

You can also change the author after the fact by adding --amend.

Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_1, and rel_3_0. I've adjusted the author on the commit. Thanks, Lynn, Jeff, and Garry!

Changed in evergreen:
importance: Undecided → High
milestone: none → 3.1.2
tags: added: regression
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.