missing charset definition in html print outputs in TPAC

Bug #1624846 reported by Eva Cerninakova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
2.10
Undecided
Unassigned
2.11
Undecided
Unassigned
2.9
Undecided
Unassigned

Bug Description

"Non English" characters in print output in TPAC are not displayed correctly because of missing charset definition (tested in Evergren 2.10.5).

The problem applies to the TPAC templates
- openils/var/templates/opac/record/print.tt2
- openils/var/templates/opac/myopac/receipt_print.tt2

To solve the problem, it is necessary to add a charset definition
  <meta charset="utf-8" />
to the HTML head section of both tt2 files.

Dan Scott (denials)
Changed in evergreen:
status: New → Confirmed
tags: added: encoding
Revision history for this message
Dan Scott (denials) wrote :

I checked this with Chrome 54.0.2840.27 beta (64-bit) and Firefox 48.0.1 on Linux, and was able to reproduce the problem on Firefox. It seems Chrome is defaulting to UTF-8 in the absence of any other declaration these days.

Great catch Eva! This is a fix we want as well; I've gone ahead and created a branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1624846_print_charset_header that implements the fix.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.next
Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks, Eva and Dan! Picked to master, rel_2_10, and rel_2_9.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.next → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers