Patron search code does not recognize empty patron group

[Mike Rylander]

In some situations, the patron search code will send an empty or NULL patron group string as part of the search parameters. This is not recognized and causes long (to the point of timing out) search calls. This can be avoided by checking for the presence of a search value.

[Mike Rylander (mrylander)]

And, here's the branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp1537812-patron_search_timeout

It is not clear where the long-running queries are coming from, though it is
likely either the actual patron search interface or from the duplicate check
performed during patron registration. Therefore, testing is made particularly
difficult.

This is backport-able, and should be, IMO.

[Ben Shum (bshum)]

Well... I tested the patch as given and encountered some problems.

1) there's a missing semi-colon after the last changed line @addr_key_list; without it storage fails to start and Evergreen is super unhappy.

2) I tried searching for patrons and I keep coming up with no results.

So I think something is broken here. Passing back to Mike for some more eyes.

[Galen Charlton (gmc)]

Also noting that patch applies due to the accent-squashing change; removing milestone targets for now.

[Terran McCanna (tmccanna)]

I'm not sure how to test this, but adding in needsrebase tag since the patch is several years old and presumably needs rebasing before it can be tested.