Remove unused self checkout org unit setting

Bug #1455606 reported by Jeff Godin
26
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

There are currently two similarly-named org unit settings related to requiring patron passwords before a patron can use the web based self checkout interface.

The setting named circ.selfcheck.require_patron_password is unused, and can/should be removed.

Working branch to follow.

Thanks to Lynn Floyd for pointing this out.

Revision history for this message
Jeff Godin (jgodin) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Jeff Godin (jgodin) → nobody
milestone: none → 2.7.6
milestone: 2.7.6 → 2.8.2
milestone: 2.8.2 → 2.7.6
milestone: 2.7.6 → none
milestone: none → 2.next
Revision history for this message
Ben Shum (bshum) wrote :

Adding a reminder that the org unit history tables might contain this setting if say, a library tried to use the setting not knowing which setting was redundant and unused. If there is such an entry in the settings history, the upgrade script will fail due to these leftover entries.

Already spoke with Jeff on this, but removing the pullrequest tag and assigning back to him to finish up.

tags: removed: pullrequest
Changed in evergreen:
status: New → In Progress
assignee: nobody → Jeff Godin (jgodin)
Changed in evergreen:
milestone: 2.next → 2.9-alpha
Changed in evergreen:
milestone: 2.9-alpha → 2.9-beta
Changed in evergreen:
milestone: 2.9-beta → 2.9.0
no longer affects: evergreen/2.7
no longer affects: evergreen/2.8
Changed in evergreen:
importance: Low → Wishlist
milestone: 2.9.0 → 2.next
Revision history for this message
Chris Sharp (chrissharp123) wrote :
Changed in evergreen:
assignee: Jeff Godin (jgodin) → nobody
status: In Progress → Confirmed
tags: added: pullrequest signedoff
Revision history for this message
Ben Shum (bshum) wrote :

Tested everything and appears to be working as intended with the removal of the unused setting. Added a release note and pushed the whole thing to master for 2.12. Thanks Jeff and Chris!

Changed in evergreen:
milestone: 2.next → 2.12-beta
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.