Metarecord holds from staff client pulls in staff barcode

[Terran McCanna]

When placing a hold in Evergreen 2.7 Staff Client:

If I enter the patron barcode before clicking on Advanced Hold Options, the patron info carries to the next screen correctly.

However, if I do NOT enter a patron barcode before clicking Advanced Hold Options, the advanced screen places the staff barcode into the "Place hold for patron by barcode" field (so, "Place hold for patron by barcode" and "Place this hold for me" are both directed to the staff person). Expected behavior would be to leave the "Place hold for patron by barcode" option blank until the patron's barcode is scanned in.

[Adam Bowling (abowling)]

Added a fix for this behavior. Also fixed the population of the input radio option after clicking "Advanced Hold Options"

user/abowling/lp1406387_advanced_hold_option_fix

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=e8fcc426714b000e969a8143bf292f78e7057cbe

[Blake GH (bmagic)]

This code has a merge conflict with master. Adam: do you mind rebasing it?

[Michael Peters (mrpeters)]

Blake,

Adam is currently tied up with other duties, but I've rebased it -- the only conflict was in the Template Toolkit code. Testers/sign-off appreciated!

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters/lp1406387_fix_hold_placement_advanced_options

[Mike Rylander (mrylander)]

I haven't tested the code live, but there's a typo in the first hunk of the patch: is_requetor != is_requestor

[Blake GH (bmagic)]

Good catch Mike! Should I make that change an put it on the sandbox? If it gets sign offs it will need TLC.

[Kathy Lussier (klussier)]

To help get this ready for the Sandbox, I've made the typo fix in a branch at working/user/kmlussier/lp1406387_fix_hold_placement_advanced_options

[Michael Peters (mrpeters)]

My apologies, folks. I've corrected the typo in the original branch. Adam sends his apologies as well.

user/mrpeters/lp1406387_fix_hold_placement_advanced_options has had a --force push to correct the typo

[Terran McCanna (tmccanna)]

mrpeters made one additional change - the final tested version is at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=5dc3821e33aa94fe7e2b55e12f8ed3f14f58f060

kmlussier applied this patch to a sandbox and I tested it successfully.

I have tested this code and consent to signing off on it with my name, Terran McCanna and email address, <email address hidden>.

[Ben Shum (bshum)]

Pushed to master and backported to rel_2_9 and rel_2_8. Thanks for testing Terran!