marc_export calls non-existent MARC::Record->id()

[Jason Stephenson]

Evergreen Version: 2.7+
OpenSRF Version 2.4.0+ (N/A)
PostgreSQL Version: 9.1/9.3 (N/A)

While looking into bug 1502152, I noticed that marc_export calls a non-existent method on MARC::Record. This method should actually be invoked on a different object, usually $are.

No one has likely seen this bug, yet, as it happens in error-handling code that is not likely to get called very often. It seems to be more likely to be noticed if you are dumping authority records.

A branch to correct this will be added soon.

[Jason Stephenson (jstephenson)]

I was able to trigger this by dumping all of the authority records from my database.

Here is the error message I received:

Can't locate object method "id" via package "MARC::Record" at /openils/bin/marc_export line 786.

Since the error occurred during error handling with no eval of its own, marc_export ceased exporting records at that point.

I have a fix prepared, but I want to give it a run through before pushing it to the working repo.

[Jason Stephenson (jstephenson)]

Branch with fix in working/user/dyrcona/lp1502156_fix_marc_export_calls_nonexistent_method

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1502156_fix_marc_export_calls_nonexistent_method

[Galen Charlton (gmc)]

Pushed to master, rel_2_9, rel_2_8, and rel_2_7. Thanks, Jason!