Libary Settings Editor History Database Trigger and Function Missing from Upgraded Schemas

[Jason Stephenson]

The 002.schema.config.sql file creates a database function, limit_oustl, and a trigger, limit_logs_oust, on config.org_unit_setting_type_log that do not appear in an upgraded database. Their absence likely stems from the fact that they are missing from 0623.schema.YAOUS-log-table.sql, the upgrade script that creates the table upon which the trigger and function operate.

Furthermore, the limit_oustl function appears to have a bug in that it does not take org. unit into account when limiting the number of history entries kept. It keeps only the five latest settings on a global basis and not the latest five for each org. unit. It should actually take the org. unit from the NEW row into account when determining what rows to delete and/or keep.

[Jason Stephenson (jstephenson)]

Branch pushed to working repo at user/dyrcona/lp1450561-restore-coustl-limit-function-and-trigger

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1450561-restore-coustl-limit-function-and-trigger

[Ben Shum (bshum)]

Seems logical to me. Pushed to master and backported to rel_2_8 and rel_2_7. One minor change in filename, I fixed a typo from lmit to limit in the name of the SQL upgrade script.