Clark Kent should write its lock file after it forks
Bug #1435966 reported by
Jason Stephenson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned | ||
2.6 |
Fix Released
|
Low
|
Unassigned | ||
2.7 |
Fix Released
|
Low
|
Unassigned |
Bug Description
Eg Version: 2.7.1 (affects all prior versions)
OpenSRF: 2.4 (N/A)
Postgresql: (N/A)
O/S: (N/A)
The reporter, clark-kent.pl, writes it's process ID (pid) to the lock file before it forks into the background. This means that the pid in the lock file cannot be used to stop the running reporter process. At best, the pid will reference no running process. At worst, you will kill some other unknown process on a busy system if all pids have been cycled since Clark started or if the system uses a randomized process for assigning process IDs.
A branch to fix this will be forthcoming....
Changed in evergreen: | |
status: | New → Confirmed |
importance: | Undecided → Low |
milestone: | none → 2.8.0 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Branch in user/dyrcona/ lp1435966_ reporter_ pid_fix in the working repo:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dyrcona/ lp1435966_ reporter_ pid_fix