More right-click authority cleanup

[Mike Rylander]

Back in bug 1175308 I added some logic that improves the behavior of the MARC editor's right-click authority popup. Now we need to go a little farther and adjust that logic to be more careful about which subfields it uses to browse for authority records. Specifically, it should only use controlled subfields.

Code to do that coming as soon as I have an LP number with which to stamp it... :)

[Mike Rylander (mrylander)]

Here's the code: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/miker/authority-right_click-sorting

[Kathy Lussier (klussier)]

Hi Mike,

I might take a look at this patch. Can you give me an example of the problem that occurred pre-patch?

Thanks!
Kathy

[Mike Rylander (mrylander)]

FTR, in IRC I said:

[10:54:16] <eeevil> kmlussier: the pre-patch bug is that we were searching on all subfields, not just controlled ones, with the right-click. so, extraneous (from the authority POV) breaks the search

Thanks for poking at this, Kathy!

[Gislaine Hamelin (gislaine-hamelin)]

Just so I understand this bug (I believe we may have reported it years ago), what is the behaviour? You right click and what is the error?

[Dan Wells (dbw2)]

Remington loaded this on our test server, and it works fine in his and my testing. Pushed to master through rel_2_6. Thanks, Mike!