ACQ should apply a default owning lib to copies managed via batch update

[Bill Erickson]

Evergreen 2.4+

Copies created or edited via the PO batch operation interface should be given an owning_lib value when none is applied. With a default, locations for whom the PO ordering agency matches the item owning lib, a value no longer has to be manually applied.

There are cases in the wild of users forgetting to apply an owning lib for batch-created copies, assuming the owning lib would be applied magically, resulting in failures down the road when the value is null. Surely this is a training issue, but it's also an easy one resolve by providing a sane fall-through mechanism.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/acq-batch-update-default-owning-lib

[Jennifer Pringle (jpringle-u)]

In the case of multi-branch libraries we do want the owning library to be blank if a staff member does not fill it in so that it results in an error when staff try to activate the purchase order. This then prompts staff to go back and enter the correct owning branch for the line items. If the system fills in the default location of the picklist org unit than the library will most likely end up ordering the copies for the wrong branch resulting in confusion for staff when the items are received and confusion for patrons if the item they have placed a hold on actually belong to another branch (as some branches apply age hold protection on new items).

The current error message is not very helpful as most library staff don't know what it means -"Event: 1586:ACTOR_ORG_UNIT_NOT_FOUND -> The requested actor_org_unit was not found". Something along the lines of "Owning library not found. Please check your line items to ensure each has an owning library assigned." would be more helpful

It would be nice to be able to set a default for single branch libraries as the owning library will always be the same for them.

[Bill Erickson (berick)]

That's a good point, Jennifer. It sounds like we need to make the option for a default a setting (i.e. not automatic) and in cases where the setting is not applied, we need a warning that appears next to the PO Activate link that prevents activation, like the no-item-price and zero-copy warnings. With this, you could still cause the not-found error by manually loading bibs and items for a lineitem (before activation), but you would know why it happened, because the warning would be right at the top of the page.

[Jennifer Pringle (jpringle-u)]

The option for a default setting and a warning beside the PO Activate link preventing activation if the owning library has been entered sounds perfect!

[Jennifer Pringle (jpringle-u)]

Sorry the above comment should say "hasn't been entered".

[Bill Erickson (berick)]

Removing pullrequest, since the code as-is does not represent the discussion that followed.

[Christine Burns (christine-burns)]

Evergreen 3.1

Acquisitions Wishlist request

New Library Setting to add the option of setting a default owning library and in cases where the setting is not applied, we need a warning that appears next to the PO Activate link that prevents activation, like the no-item-price and zero-copy warnings if the owning library is missing.

[Tiffany Little (tslittle)]

Resurrecting this bug to add my +1 to Christine's suggestion. That would be really helpful for us.

[Christine Morgan (cmorgan-z)]

Also adding my +1 to Christine's suggestion. This would be really helpful for us as well.

[Andrea Neiman (aneiman)]

Equinox will be addressing this bug as part of the Angular Acq Sprint 4 work (bug 1942220), funded by the Evergreen Community Development Initiative.

[Galen Charlton (gmc)]

The pull request branch for bug 1942220 includes an implementation of the warning requested in comment 6. That branch also contains patches for bug 1981714 that introduce relevant settings.

[Ruth Frasur Davis (redavis)]

For the sake of LP cleanliness, should this also be signed off on?