overzealous unsaved data warning with MARC editor

[Jason Etheridge]

Swinging in the other direction from "possible to avoid the unsaved data warnings in the MARC editor", this bug is about how certain keypresses (particularly function keys) can lock the MARC editor and give a spurious unsaved data warning.

When this feature was originally implemented, I tried attaching a handler to the change event for the textboxes in the interface. But this event would not fire until focus left the textbox being edited and went to another widget in the same page. Thus, if you did something like Control+W to close the tab, the change event would not fire, the page would not be locked, and you'd close the tab losing unsaved data. So instead, we put a handler on the keypress event, and tried to ignore likely non-editing keypresses (anything with a modifier key held down like Control or Alt).

But this didn't catch function keys like F3 for loading a new OPAC, which causes the interface to lock.

This branch changes that (and does some code cleanup in the process):
collab/phasefx/marceditor_locking @ working/Evergreen.git
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/marceditor_locking

[Pasi Kallinen (paxed)]

Tested, and works for me. Updated to current master, and signedoff: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/marceditor_locking-signoff

[Dan Wells (dbw2)]

Had to resolve conflicts with master yet again. Stop the madness! Pushed!

Thanks, Jason and Pasi.

[Dan Wells (dbw2)]

I am targeting this to other active branches as well. The changes to marcedit.xul are almost entirely a find and replace, so in retrospect, it is probably easier to redo that file than to actually resolve any conflicts with older versions.

[Ben Shum (bshum)]

Marking as "won't fix" for 2.2 because we are outside the 2.2 support timeframe for non-security bug fixes.