renewing items not checked out fails unintuitively

Bug #1096237 reported by Anoop Atre
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Won't Fix
Undecided
Unassigned

Bug Description

Evergreen Version: 2.3.1 & 2.2.0

This issue was reported by one of our libraries:

======
In version 2.0 if you accidentally did a "Renew" on an item that had never been checked out, you would get an advisory message about that situation that explained why the renew failed.

In version 2.3 if you accidentally run an item that has not been checked out through the "Renew" function, you get an "Unhandled Error" FIXME message that only says "Renew Failed for itemid". (Screen print attached.)

This is a much less helpful result and doesn't give staff useful information about why there was a problem.

Can the old code be restored?
======

I have confirmed this on an Evergreen instance running 2.3.1 & 2.2.0

Debug output from the 2.3.1 version:
==============

Please open a helpdesk ticket and include the following text:

Fri Jan 04 2013 16:20:20 GMT-0500 (Eastern Standard Time)

Renew Failed for 10251189

[

 {
  "stacktrace":"/usr/local/share/perl/5.10.1/OpenILS/Application/Circ/Circulate.pm:800 /usr/local/share/perl/5.10.1/OpenILS/Application/Circ/Circulate.pm:277 /usr/local/share/perl/5.10.1/OpenSRF/Application.pm:586",
  "ilsevent":"1002",
  "pid":"4483",
  "desc":"Someone attempted to retrieve a user from the system and the user was not found",
  "textcode":"ACTOR_USER_NOT_FOUND",
  "servertime":"Fri Jan 4 16:20:20 2013"
 }

]
==============

Tags: staffclient
Changed in evergreen:
status: New → Triaged
milestone: none → 2.4.0-alpha
Revision history for this message
Jason Etheridge (phasefx) wrote :

collab/phasefx/renew_ui_fix @ working/Evergreen.git

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/renew_ui_fix

commit ca6d11b1305a57db9254f21680a4880750b40162
Author: Jason Etheridge <email address hidden>
Date: Wed Jan 9 15:14:27 2013 -0500

    lp10962307 renewing items ACTOR_USER_NOT_FOUND err

    This fix simply stops the Skull & Crossbones error dialog from happening when a
    renewal call results in ACTOR_USER_NOT_FOUND. It doesn't address the fact that
    we used to get ACTION_CIRCULATION_NOT_FOUND instead, which is more fathomable by
    staff.

    Signed-off-by: Jason Etheridge <email address hidden>

tags: added: pullrequest
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-alpha1 → 2.4.0-beta
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → none
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.5.0-m1
Revision history for this message
Ben Shum (bshum) wrote :

Tested and yes, it doesn't pop the fixme broken error anymore. But as indicated it also does not show any warning of success or failure. I was testing by pulling an item into the item status and then clicking "renew items" from the selection choices.

Personally, I'd be in favor of figuring out a way of creating a safe warning to display to end users for this issue rather than closing this bug by just solving the resulting error alone. Removing pullrequest pending further discussion.

Changed in evergreen:
milestone: 2.5.0-m1 → 2.5.0-m2
tags: removed: pullrequest
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m2 → 2.5.0-alpha1
Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Ben Shum (bshum)
no longer affects: evergreen/2.2
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-alpha2 → 2.5.0-beta1
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-beta1 → 2.5.0-rc
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-rc → none
Revision history for this message
tji@sitka.bclibraries.ca (tji) wrote :

We are on 2.4. We have a recent report on this issue. Though the library claimed the error popped up when retrieving an item on Items Status, it is not hard to figure it out from the message that renewal had been attempted.

I prefer a safe warning than 'silence'.

Tina/Sitka

Revision history for this message
Jason Stephenson (jstephenson) wrote :

This is caused by the same problem as bug 638509. I have a work in progress branch as part of some MassLNC development that should resolve this issue. My code is not ready for public review, yet, as it has not been tested by MassLNC.

Changed in evergreen:
status: Triaged → Confirmed
no longer affects: evergreen/2.3
no longer affects: evergreen/2.4
no longer affects: evergreen/2.5
Revision history for this message
Terran McCanna (tmccanna) wrote :

In web client, an error pops up.

Changed in evergreen:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.