View Shelf Expired Holds doesn't work correctly unless all holds load first.

[Steve Callender]

Tested in 2.2.0, when accessing the browse hold shelf from Circulation > Browse Hold Shelf, if there are a considerable amount of holds to load (more than 1 page worth), if checkmark "View Shelf-Expired Holds" before all the holds finish loading, the system will just continue to display all holds rather than just the expired ones.

It looks like the code in question is in Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm under the fetch_captured_holds method.

It looks like both API's (captured and expired) use the same method, fetch_captured_holds, and in the middle of the method it checks to see if it was the expired API that was used to adjust it's database query accordingly. Unless the capture method seems to run it's full course first, it doesn't work when switching to the expired API too quickly.

[Ben Shum (bshum)]

I've seen this occur as well. Marking confirmed and assigning targets.

[Chris Sharp (chrissharp123)]

I'm not seeing this in 2.9. There is no longer a "View Shelf-Expired Holds" checkbox, but I'm assuming "View Clearable Holds" is the same function and when I check that box as the full results are loading, the screen clears and I get the clearable holds. If this is still happening, please provide details.

[Andrea Neiman (aneiman)]

Refers to XUL client