Purge Circulations function does not work and has other issues

[Thomas Berezansky]

Due to a type issue (bigint doesn't auto-convert to integer) the purge circulations function does not appear to work currently.

In addition I discovered that it could potentially delete circulations that are open and would leave circulations that should be purged alone when other circulations overshadowed them.

The branch below contains a series of commits to fix the various issues I found, including adding some settings to determine new behavior where I disagreed with the current behavior but was told the current behavior was desired.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/purge_circulations_updates

[Jason Stephenson (jstephenson)]

I thought that I was going to get to this by this past weekend, but I have been sick and so I did not. I am removing myself as assignee so someone else can have a look if they want. I don't know when I'll be able to get to this as I have a number of other things coming up.

[Jason Stephenson (jstephenson)]

All right. This is working for me, so I signed off on Thomas's commits and pushed to a collab branch.

I didn't push to master because I added a commit to create a purge_circulations.srfsh script, and I figure someone else ought to sign off on that and push it.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dyrcona/purge_circulations_updates

[Dan Wells (dbw2)]

Signed off on last commit and pushed the whole thing to master. Backporting is still a TODO, for now.

Thanks again, Jason and Thomas.

[Dan Wells (dbw2)]

P.S. I am assigning myself to the backports, so I don't forget, but if anyone else wants to do it, please feel free!