TPAC: schema.org MusicRecording object is wrong type for albums; Person names should not include dates

Bug #1165180 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

* Evergreen 2.3 / master

When we added schema support in Evergreen 2.2 in the TPAC, we did a quick and dirty job of it. This is an attempt to fix some of the problems that we've uncovered since then.

Most egregious was the mapping of MusicRecording for albums; it turns out there is a MusicAlbum object for this purpose. Correspondingly, we also need to identify the MusicGroup as a separate object.

Per http://schema.org/Person, the birth date and death date are not supposed to be part of the name of a Person. We can separate these out correctly based on subfield d for 100 fields.

Finally, we can easily add cartographic materials as a mapping to the Map object type.

See the top two commits in user/dbs/schema_org_album_person_fixes in working repository.

Tags: pullrequest
Revision history for this message
Dan Scott (denials) wrote :
Revision history for this message
Dan Scott (denials) wrote :

Make that the top three commits. I added some further logic to break out Organization vs. Person types in the authors display, which is even more correct for schema.org.

Ben Shum (bshum)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Mike Rylander (mrylander) wrote :

Master has it. Thanks, Dan!

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
Revision history for this message
Bill Erickson (berick) wrote :

Code does not pick cleanly into rel_2_3. If we get an 2.3 compat branch soon, I'll test/signoff, otherwise will mark as won't-fix for 2.3.

no longer affects: evergreen/2.3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.