Patron Editor can enter erroneous values for Claims-returned

[Steven Chan]

In the staff client, Patrons interface, Edit screen, when mouse-scrolling up and down the Edit form, it is possible to inadvertently change the value in Claims-returned Count or Claims Never Checked Out Count field. It will happen if the mouse hovers over either
data field while using the mouse wheel.

Both data fields use the dijit.form.NumberSpinner widget to provide a 'spin' behaviour. There seems to be an erroneous behaviour with the widget, as follows.

1. The data fields are of datatype int, and int is mapped into using dijit.form.NumberTextBox, which somehow gets changed to NumberSpinner, an extension of NumberTextBox.

2. If the user hovers over one of the data fields and adjusts the mousewheel, it seems the input field is auto-focussed and up and down events are then handled.

All other data fields require an explicit click to focus on the input field and it should be no different for these two data fields.

A quick fix involves cancelling the mouse scroll event as it propagates to input fields in table rows that are using the dijit.form.NumberSpinner widget, because the mouse scroll would be applied too early by the widget, before the user has intentionally focussed on one of the input fields. Now, mouse scrolling has no effect on the two input fields; it will only have an effect in scrolling the page up or down.

P.S. We found our production database contained about a hundred patron records with unusually high count values, probably due to the problem. We identified these patron records and 'corrected' the count values.

Evergreen version 2.2

[Ben Shum (bshum)]

Works for me, thanks Steven! Picked to master, rel_2_4, and rel_2_3. Marking rel_2_2 as "won't fix" since it's outside our maintenance window for bugs now.