TPAC - set autofocus to user input when placing holds in staff client

[Ben Shum]

Evergreen master

When placing holds in TPAC via the staff client, the focus had been on the basic search field above. Change this to have autofocus on the input field for the hold user by default.

This can potentially save staff from having to perform an extra click to select the input field. Now they can immediately begin entering the barcode of the user they plan to create a hold on behalf of.

I have a working branch here: working/user/bshum/tpac-hold-usr-autofocus

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/tpac-hold-usr-autofocus

[Ben Shum (bshum)]

One thing I'm not entirely sure about is eliminating the focus from basic search on the place hold page also affects the public catalog view for patrons when they're logged in and creating holds. The field for hold user doesn't exist for them, so they don't get a focus to it; there doesn't appear to be any focused text input fields at all. But I feel that not having the focus on the search box is fine in that scenario. With creating a hold, I would suppose users are most interested in checking their hold options (pickup, notification, etc.) and then hitting the Submit button to place the hold and not looking to see what search term they were using prior to placing that hold.

Either way, not sure if it's a problem or not really a big deal.

[Ben Shum (bshum)]

tsbere suggested putting the basic_search = f; block inside a test for ctx.is_staff. This allows us to sidestep the issue of what we focus on for the public catalog.

Added to commit and force pushed to same branch name for consideration.

[Ben Shum (bshum)]

Per csharp's question on whether this might be a usability issue that ought to be fixed in previous versions of Evergreen, a backport branch was also created for rel_2_3. See: working/user/bshum/tpac-hold-usr-autofocus-rel_2_3

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/tpac-hold-usr-autofocus-rel_2_3

[Mike Rylander (mrylander)]

I like it. Thanks, Ben! Picked into all targeted branches.