integrated search box on Evergreen staff client portal page - empty results when searching terms with Czech chararcters

[Eva Cerninakova]

When searching for terms containing extended Czech characters (like "aplikovaná psychologie" , "dějiny", "Baštecká", "manažerská" etc.) on Evergreen Staff Client Portal Page (Evergreen version 2.2.2), empty results are returned, see http://knihovna.jabok.cz/Evergreen/bugs/integrated_search_box.jpg

I guess it is caused by missing UTF-8 charset attribute in form in the source code of the Portal page.

[Michael Peters (mrpeters)]

I'll take a look at this, since I created it. Thanks for pointing it out.

[Michael Peters (mrpeters)]

Eva,

Could you give this a test?

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=94a935b8a59d94d553491b7a69215a5c9e970ad3

-Mike

[Pasi Kallinen (paxed)]

This bug still seems to happen, with the TPAC.

Search for anything containing non-US ASCII characters directly from the staff client portal input bar. The search results page shows the searched string as containing unknown UTF characters (U+FFFD, the replacement char).

mrpeters' fix above didn't work.

[Dan Scott (denials)]

The fix is to change the escape() calls to encodeURIComponent() calls.

[Ben Shum (bshum)]

Dan Scott took a look at this and suggested replacing escape() with encodeURIComponent() to better handle utf8 characters.

See working branch at: working/user/bshum/lp1081576

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1081576

[Pasi Kallinen (paxed)]

Works for me. Signoff at user/paxed/lp1081576-signoff

[Ben Shum (bshum)]

Thanks for testing Pasi! I've picked this to master, rel_2_4, rel_2_3. Also rel_2_2, though that required a tiny bit of massaging since the code there is slightly different due to xulrunner differences between branches.