eg_pbx_allocator.pl - lock file detection warnings

[Josh Stompro]

Hello, when the eg-pbx-allocator.pl detects an already existing lock file, the following warnings are detected.

Use of uninitialized value $pid in scalar chomp at /usr/local/bin/eg-pbx-allocator.pl line 255.
Use of uninitialized value $pid in concatenation (.) or string at
+/usr/local/bin/eg-pbx-allocator.pl line 259.
Use of uninitialized value $pid in concatenation (.) or string at
+/usr/local/bin/eg-pbx-allocator.pl line 260.
lock file present! at /usr/local/bin/eg-pbx-allocator.pl line 264.
verbose output ON

I think that the lock file detection code isn't correct.
http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/asterisk/pbx-daemon/eg-pbx-allocator.pl;h=2db674f35a537ee068bf8d5218041b8ab85db8d0;hb=HEAD#l252

 252 sub lock_file_test {
 253 if (open FH, $config{lock_file}) {
 254 my $pid = <>;
 255 chomp $pid;
 256 close FH;

I think that "my $pid = <>;" isn't correct, that seems to be waiting for STDIN or a filename from the command line. I think it should be "my $pid = <FH>;"

Working branch on the way.
Josh

[Josh Stompro (u-launchpad-stompro-org)]

Working branch added at user/stompro/lp1739044-eg-pbx-allocator-lock-detect

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1739044-eg-pbx-allocator-lock-detect

Josh

[Galen Charlton (gmc)]

Works for me. Signoff branch here: user/gmcharlt/lp1739044_signoff

[Galen Charlton (gmc)]

I've gone ahead and merged this to master, rel_3_1, and rel_3_0. Thanks, Josh!