Conjoined items do not display without an extra copy attached to the record
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
2.12 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
* Evergreen 2.10+
The stock template for copy table display (Open-ILS/
[%- IF has_copies; %]
However, foreign copies from conjoined items are stored in $ctx->foreign_
However, if there is no normal copy attached to the record, then foreign copies are not displayed.
The solution (discovered independently by Dan Wells and Dan Scott) is to make has_copies true if $ctx->foreign_
[%- IF has_copies OR $ctx->foreign_
will suffice.
Changed in evergreen: | |
milestone: | none → 3.0-alpha |
no longer affects: | evergreen/2.11 |
no longer affects: | evergreen |
Changed in evergreen: | |
milestone: | none → 3.0-alpha |
no longer affects: | evergreen/3.0 |
tags: | added: pullrequest |
Changed in evergreen: | |
assignee: | nobody → Mike Rylander (mrylander) |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Here are a couple quick branches that implement the change mentioned above.
For master: git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/collab/ dbwells/ lp1703678_ show_foreign_ copies
http://
working/ collab/ dbwells/ lp1703678_ show_foreign_ copies
For 2.12, etc.: git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/collab/ dbwells/ lp1703678_ show_foreign_ copies_ 2_12
http://
working/ collab/ dbwells/ lp1703678_ show_foreign_ copies_ 2_12
The 2.12 version is what we are running in production, but master had some nearby changes, so that patch did not apply cleanly. The branch provided seems like a simple conflict resolution, but is untested, so please take additional caution.
Dan S. also noted in IRC that a few other changes may be needed to polish up foreign copy support, so other patches may yet be incoming.