ACQ: Allocate to Fund drop down menu (in Funding Source) Not Following Precedents Set by Other Fund Menus

[Jennifer Pringle]

Evergreen 2.4 Beta
Ubuntu 12
Postgres 9.1.4

In the Funding Source details page (Admin -> Acquisitions -> Funding Sources and then click on the name of the funding source) there is a drop down menu under "Create Allocation". This drop down menu lists all of the funds available to the user to allocate money to.

There are currently two problems with this drop down menu:
1. The year is not displayed beside the fund code in brackets.
2. Funds that have been set to Active = FALSE appear in this menu.

These two problems mean that after funds have been propagated for a new fiscal year the user cannot distinguish between funds from the previous and current fiscal years as the same codes are used. For example, a library that has three fiscal years in Evergreen will have the code AF display three times in this drop down menu for their Adult Fiction funds.

This dropdown menu should:
1. Display the year in brackets beside each fund code (as is seen throughout the acquisitions module).
2. Not display funds that have been set to Active = FALSE. (Users can activate funds to allocate money to them and then deactivate them if they do not want the fund to be used yet.)

The current workaround for this is to allocate credit from within the Fund details page rather than the Funding Source details page. However, when users go through the Funding Source details page and select the wrong fund the only way to correct the problem is to delete the allocation from the database.

This problem becomes apparent after a library has propagated their funds and goes into allocate money to those funds for their new fiscal year.

This bug is present on 2.0, 2.2, and 2.4 beta

[Tim Spindler (tspindler-cwmars)]

Related to this, I have also found in version 2.6 the fund drop down limits to what looks like 50 funds so if you have more than 50 funds it cuts it off the list. I have seen this in version 2.5.3.

[Angela Kilsdonk (akilsdonk)]

I can confirm that this is still present in 2.7.5.

[Martha Crawley (mcrawley)]

Allocating and transferring funds throughout the year are very difficult to manage for all the above reasons (we have 188 funds). It's very important to us that improvements be made as soon as possible.

[Holly Brennan (hollyfromhomer)]

This is an important issue for us because we receive funding dispersed over two different fiscal years. We need to be able to remove the inactive funds from the list -- without deleting them entirely.

[Chris Sharp (chrissharp123)]

I just investigated this issue. The problem with displaying the year is an inherent limitation in how the fund selector dropdown is implemented. It uses dijit/form/FilteringSelect (see https://dojotoolkit.org/reference-guide/1.10/dijit/form/FilteringSelect.html for more-recent-than-what-we-use documentation on this feature), which has attributes "searchAttr" and "labelAttr" which only allow search/display of a single field, in this case, the fund code. My search of the web did not reveal any way to display anything else.

This is all to say that the display needs to be reimplemented to be like the fund dropdown in the lineitem batch updater (for example), that *does* show the code and year as requested.

As to whether the data store that's used to populate the dropdown can filter on active = false, I currently can't tell.

Hopefully someone more knowledgeable and experienced than me can chime in with advice about how to proceed.

[Dan Wells (dbw2)]

Here's a fix attempt:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dbwells/lp1175293_fund_dropdown_fix

working/collab/dbwells/lp1175293_fund_dropdown_fix

This follows the example of a few other fund dropdowns, and really works around the issues Chris mentions by building off the AutoFieldWidget logic. There may be a better way to do it, but this seems to work, and isn't terrible looking.

At this point, I have only tested with an admin account, so the perm check (MANAGE_FUND) could use additional scrutiny.

[Chris Sharp (chrissharp123)]

This works for me! Thanks, Dan!

Signoff branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1175293_fund_dropdown_fix_signoff

[Kathy Lussier (klussier)]

Thank you Dan and Chris. I know this will make many of our acq people happy. Merged to master, 2.11, and 2.10