Unicode strings stored by util.file can come back mangled

[Galen Charlton]

Some interfaces in the XUL client, such as the transit list, build org unit selectors by reading the names and IDs of OUs from the offline_ou_list XUL profile file that's initialized during login. However, since at the moment util.file doesn't account for the fact that nsIOutputStream (and children) expect JavaScript clients to only write ASCII data, non-ASCII OU names can get mangled. E.g.,

ბიზნესისა

can become

ÑØÖÜÔáØáÐ

[Galen Charlton (gmc)]

A patch is available at the tip of the user/gmcharlt/lp1641208_unmangle_utf8_in_utl_file branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1641208_unmangle_utf8_in_utl_file

I can think of a couple other ways to implement this:

- move the conversion to write_content/get_content so that all uses of util.file will get the conversion, which would cover more ground (e.g., receipts) but require more testing.
- instead of using nsIScriptableUnicodeConverter in get_object/write_object, convert the non-ASCII characters to Unicode escape sequences after producing the JSON.

[Jason Etheridge (phasefx)]

Thanks Galen! I also tried a compiled client and confirmed that it fixes manifestations of this bug in workstation registration and offline patron registration.

Pushed to master, rel_2_11, and rel_2_12