use "Active On" rather than "Activate" as header in TPAC holds tables
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Won't Fix
|
Low
|
Unassigned | ||
2.10 |
Won't Fix
|
Low
|
Unassigned | ||
2.11 |
Won't Fix
|
Low
|
Unassigned |
Bug Description
The patch for bug 1576502, in addition to changing how fulfilled holds are displayed in the hold history tab in the OPAC my account page, also changed a column heading from "Activate On" to "Activate". Per the following discussion in #evergreen, "Active On" (or maybe a better term?) should be used instead:
[10:47:44] <gmcharlt> kmlussier: around for a quick question?
[10:49:44] <kmlussier> gmcharlt: I'm here now
[10:50:17] <gmcharlt> kmlussier: I'm considering this for backporting to 2.10: http://
[10:50:50] <gmcharlt> and my question is this: whence the /Active On/Activate/ in the patch?
[10:52:14] <gmcharlt> it feels like it snuck in; at any rate, it doesn't seem on point with respect to the bug
[10:52:19] <kmlussier> gmcharlt: Just a sec...it was a long time ago and I need to refresh my memory
[10:52:29] <gmcharlt> sure
[10:54:05] <kmlussier> gmcharlt: OK, it looks like I addressed it in the original bug report where I tried to add it to the Terran's original change. https:/
[10:54:06] <pinesol_green> Launchpad bug 1275118 in Evergreen "Holds history displays canceled holds as active" [Medium,Fix released]
[10:55:08] <kmlussier> gmcharlt: I think I was trying to make it consistent with what displays in the patron's list of current holds. But, you're right, it's not really on point with the bug description.
[10:58:16] <gmcharlt> kmlussier: I'm not a fan of "Activate" as the column heading, as it's a verb, but there's no action one can take in that column
[10:58:44] <gmcharlt> but that said, I don't feel strongly about it, so I'm inclined to backport as is on the basis of making things more consistent
[10:59:04] <gmcharlt> and discussion about the heading can be the subject of a new bug
[11:00:19] <kmlussier> Yes, I can see your point. At the time, I was thinking Activate was a better column heading, but today, "Active On" seems better. I could go with that as long as it's the same in both places.
[11:00:41] <gmcharlt> @coinflip
[11:00:43] <pinesol_green> gmcharlt: It reads like a Nigerian 419 scam, but I think it is a sincere question sent to the wrong list.
[11:00:59] <gmcharlt> @decide "Active On" or "Activate"
[11:00:59] <pinesol_green> gmcharlt: go with Active On
[11:01:33] <gmcharlt> there we have it! ;)
[11:01:45] <gmcharlt> I'll backport as is, then open a new bug
[11:06:39] <kmlussier> gmcharlt: Thanks. If you like, I can create a branch for the new bug.
Changed in evergreen: | |
importance: | Undecided → Low |
tags: |
added: opac removed: tpac |
+1