The make_release script should always create a DB upgrade script.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
2.10 |
Fix Released
|
Undecided
|
Unassigned | ||
2.9 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Building the 2.9.5 tarball yesterday, I was surprised to discover that the make_release script does not create a DB upgrade script when there are no DB upgrades to apply. At a gross level, this makes perfect sense.
However, I think it will lead to confusion when people try to upgrade and there is no upgrade script to run. Also, there will be no entry in the DB upgrade log that the version was applied. A newly installed system will have a log entry of the currently installed Evergreen version.
I propose to modify make_release to output a minimal upgrade script that simply inserts the Evergreen version into config.upgrade_log when there are no actual database upgrades to apply.
Since this only affects maintainers building tarballs, I also suggest that this be backported to the currently supported releases, 2.9 and 2.10. If anyone disagrees, please elaborate your reasons in the comment section.
Changed in evergreen: | |
milestone: | none → 2.next |
assignee: | nobody → Jason Stephenson (jstephenson) |
status: | New → In Progress |
Changed in evergreen: | |
assignee: | Jason Stephenson (jstephenson) → nobody |
status: | In Progress → Confirmed |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
I don't disagree. I think this is a fine idea.