Email templates should always escape headers
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
2.10 |
Fix Released
|
Medium
|
Unassigned | ||
2.9 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
* Evergreen master
OpenILS/
"""
To: [%- helpers.
"""
All of the email templates in the seed values should be updated to escape the headers, so that future copy & paste efforts to create new templates magically get the appropriate values.
We might have to skip automatic upgrades in this case because of the high likelihood that we would overwrite customizations -- unless our upgrade script does something very clever like updating the row only where the template matches the previously known template. Sounds like a lot of work, but might be worth it for preventing problems where we can...
Changed in evergreen: | |
milestone: | 2.3.0-beta1 → 2.3.0-beta2 |
Changed in evergreen: | |
milestone: | 2.3.0-beta2 → 2.3.0-rc1 |
Changed in evergreen: | |
milestone: | 2.3.0-rc1 → 2.3.0 |
Changed in evergreen: | |
milestone: | 2.3.0 → 2.3.1 |
Changed in evergreen: | |
milestone: | 2.3.1 → 2.4.0-alpha |
Changed in evergreen: | |
status: | New → Triaged |
Changed in evergreen: | |
milestone: | 2.4.0-alpha1 → 2.4.0-beta |
Changed in evergreen: | |
milestone: | 2.4.0-beta → 2.4.0-rc |
Changed in evergreen: | |
milestone: | 2.4.0-rc → none |
tags: | added: i18n |
Changed in evergreen: | |
milestone: | 2.5.0-alpha1 → 2.5.0-alpha2 |
Changed in evergreen: | |
milestone: | 2.5.0-alpha2 → 2.5.0-beta1 |
Changed in evergreen: | |
milestone: | 2.5.0-beta1 → 2.5.0-rc |
Changed in evergreen: | |
milestone: | 2.5.0-rc → 2.5.1 |
Changed in evergreen: | |
milestone: | 2.5.1 → 2.5.2 |
Changed in evergreen: | |
milestone: | none → 2.6.0-beta1 |
Changed in evergreen: | |
milestone: | 2.6.0-beta1 → 2.6.0-rc1 |
Changed in evergreen: | |
milestone: | 2.6.0-rc1 → 2.6.1 |
milestone: | 2.6.1 → 2.next |
no longer affects: | evergreen/2.4 |
Changed in evergreen: | |
milestone: | 2.8-beta → 2.8.1 |
Changed in evergreen: | |
assignee: | Dan Wells (dbw2) → nobody |
milestone: | 2.8.1 → 2.8.3 |
no longer affects: | evergreen/2.5 |
no longer affects: | evergreen/2.6 |
Changed in evergreen: | |
milestone: | 2.8.3 → 2.9.0 |
Changed in evergreen: | |
milestone: | 2.9.0 → 2.9.1 |
Changed in evergreen: | |
milestone: | 2.9.1 → 2.next |
Changed in evergreen: | |
importance: | Undecided → Medium |
Changed in evergreen: | |
assignee: | nobody → Dan Wells (dbw2) |
Changed in evergreen: | |
milestone: | 2.next → 2.11-alpha |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Possible solution for the "updating existing templates" problem:
http:// pastebin. com/14sJWZ3r
Not perfect, but better than nothing (or wiping out templates).