Evergreen - Open ILS

Booking pickup stops showing captured resources after first day

Reported by Lebbeous Fogle-Weekley on 2012-02-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
2.0
Undecided
Unassigned
2.1
Undecided
Unassigned

Bug Description

For evergreen master, and it should be backportable through rel_2_0.

    Booking: make pick up interface show resources captured for reservation ...

    ... even beyond the first day of the reservation. I can think of no
    reason why this limitation existed in the first place.

This comes about as a result of discussion on the open-ils-general mailing list. The thread starts here: http://libmail.georgialibraries.org/pipermail/open-ils-general/2012-January/006091.html

Here's the code:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/relax-pickup-constraints

Mike Rylander (mrylander) wrote :

I agree with the assessment that the restriction is unnecessary, and I think I can shed some light on why it's there.

IIRC, the point was to show "hot" reservations, those that had events occur "today". Another reason may be to limit the number of reservations the function would return, but that's unlikely because the way it was 1) couldn't guarantee that and 2) would be a very heavy handed way to do it.

As a side note, I noticed an opportunity for a little refactoring. The naive_start_of_day() sub could be replaced with the string 'today', which Postgres will interpret in the way that the sub intends.

Thanks, Lebbeous!

Pushed a rebased version of this branch that implements Mike's requested change. Still at the same URL:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/relax-pickup-constraints

Mike Rylander (mrylander) wrote :

Pushed for great justice!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers