Serial Control: Use Dijit-based issuance editor

Bug #965724 reported by Dan Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.0
Fix Released
Undecided
Unassigned
2.1
Fix Released
Undecided
Unassigned

Bug Description

The serial control interfaces use editors derived from the XUL
copy editor, while the alternate control uses Dijit editors. This
branch takes a small step toward unification by using the Dijit
issuance editor within the serial control interface, with the
following benefits:

    1) Both controls will have a very similar editor look and feel
    2) Takes advantage of custom holding code wizard widget
    3) Future fixes and enhancements to the editors will apply easily
    to both controls
    4) Begin deprecating XUL serial editors

This branch doesn't yet rip out the old issuance editor code, as
that should wait until the transition is more complete.

Finally, this change is split into three commits. The first two are minor
but dependent bug fixes; I will backport them as needed once
this gets into master. The last commit is the actual editor change.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/shared_siss_editor

Tags: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

Merged!

Changed in evergreen:
status: New → Fix Committed
Revision history for this message
Dan Wells (dbw2) wrote :

Reopening this bug, as this branch was only partially applied (one commit out of three) :( This is also likely the cause of https://bugs.launchpad.net/bugs/972384, which despite only mentioning issuance creation, this probably means editing is a bit broken as well. Any chance of a beta 1a?

Changed in evergreen:
status: Fix Committed → In Progress
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Dan,

Sorry about that. I will test the missing commits and merge them sometime today.

Lebbeous

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Dan,

This tested well for me, and (although the commit log for master is confusing regarding commits from your branch), I believe all your code is in master in the intended way.

Thanks for taking such a first step toward merging the existing interfaces. Hopefully we can work together on new development, bugfixing, and simplification in serials during the next few weeks.

Lebbeous

Changed in evergreen:
status: In Progress → Fix Committed
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

(and in rel_2_2)

no longer affects: evergreen/2.2
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

2/3 of the commits in Dan's branch work as bugfixes for rel_2_1 and rel_2_0, so those commits have been pushed there now too. Thanks again Dan!

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.