acquisition request on behalf of patron will not save

Bug #985075 reported by Sally Fortin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.2
Won't Fix
Medium
Unassigned
2.3
Fix Released
Medium
Unassigned
2.4
Fix Released
Medium
Unassigned

Bug Description

In Evergreen version 2.2beta2, I tried to create an acquisition request on behalf of a patron.

Click Acquisitions -> Patron Request -> Create Request.

I entered info in the relevant fields, and tried to scroll down and tab down to the Save button. The screen would not scroll down so that I could save the request.

Revision history for this message
Sally Fortin (sfortin) wrote :

A demo of the problem can be found here:

http://screencast.com/t/IctEX5UoF

Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

This same behaviour is present if you are in a patron record and click Other -> Acquisition Requests -> Create Request.

Revision history for this message
Steven Chan (schan2) wrote :

Here is a patch.
--
steven chan
sitka cooperative

Steven Chan (schan2)
Changed in evergreen:
status: New → Confirmed
Steven Chan (schan2)
tags: added: pullrequest
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.3.0-beta2
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.3.0-beta2 → 2.3.0-rc1
Changed in evergreen:
milestone: 2.3.0-rc1 → 2.3.0
Changed in evergreen:
milestone: 2.3.0 → 2.3.1
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Steve,

Thanks for the patch! We've got to start having you sign-off (git commit -s) on your commits, though. Can you submit a new version?

Thanks.

Changed in evergreen:
milestone: 2.3.1 → 2.4.0-alpha
Revision history for this message
Ben Shum (bshum) wrote :

To Steven, see Lebbeous request for adding sign-off to git commits.

Yanking pullrequest and marking to in progress for Steven till then.

Changed in evergreen:
status: Confirmed → In Progress
assignee: nobody → Steven Chan (schan2)
importance: Undecided → Medium
Ben Shum (bshum)
tags: removed: pullrequest
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-alpha1 → 2.4.0-beta
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Revision history for this message
Steven Chan (schan2) wrote :

Here it is again, signed off.

tags: added: pullrequest
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → none
assignee: Steven Chan (schan2) → nobody
status: In Progress → Confirmed
assignee: nobody → Lebbeous Fogle-Weekley (lebbeous)
Revision history for this message
Ben Shum (bshum) wrote :

Marking as "won't fix" for 2.2 because we are outside the 2.2 support timeframe for non-security bug fixes.

Changed in evergreen:
milestone: none → 2.5.0-alpha1
Revision history for this message
Remington Steed (rjs7) wrote :

I tested Steven's patch and it works as expected. So I created a branch using his commit, rebased to master and signed off on it.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp985075_patron_acq_request_form

Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Revision history for this message
Ben Shum (bshum) wrote :

Picked to master, rel_2_4, and rel_2_3. Thanks Steven and Remington!

Changed in evergreen:
assignee: Lebbeous Fogle-Weekley (lebbeous) → nobody
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.