overzealous unsaved data warning with MARC editor
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned |
Bug Description
Swinging in the other direction from "possible to avoid the unsaved data warnings in the MARC editor", this bug is about how certain keypresses (particularly function keys) can lock the MARC editor and give a spurious unsaved data warning.
When this feature was originally implemented, I tried attaching a handler to the change event for the textboxes in the interface. But this event would not fire until focus left the textbox being edited and went to another widget in the same page. Thus, if you did something like Control+W to close the tab, the change event would not fire, the page would not be locked, and you'd close the tab losing unsaved data. So instead, we put a handler on the keypress event, and tried to ignore likely non-editing keypresses (anything with a modifier key held down like Control or Alt).
But this didn't catch function keys like F3 for loading a new OPAC, which causes the interface to lock.
This branch changes that (and does some code cleanup in the process):
collab/
http://
Changed in evergreen: | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in evergreen: | |
milestone: | none → 2.4.0-rc |
Changed in evergreen: | |
milestone: | 2.4.0-rc → 2.5.0-alpha |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
no longer affects: | evergreen/2.2 |
no longer affects: | evergreen/2.3 |
no longer affects: | evergreen/2.4 |
Tested, and works for me. Updated to current master, and signedoff: http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ paxed/marcedito r_locking- signoff